Skip to content

Conversation

@MqllR
Copy link
Contributor

@MqllR MqllR commented Aug 27, 2025

close #692

image

@fjl
Copy link
Contributor

fjl commented Oct 13, 2025

I think this is useful, and we have it implemented in Geth. However, it seems support for this is far from universal across clients, so the change can't be merged so easily.

@MqllR
Copy link
Contributor Author

MqllR commented Oct 14, 2025

thanks for the feedback @fjl. All tested clients (Geth, Erigon, Reth, Besu) appear to support this correctly. Is the spec not already frozen as outlined in https://github.com/ethereum/EIPs/blob/master/EIPS/eip-234.md ?

@fjl
Copy link
Contributor

fjl commented Oct 14, 2025

Ahh, you are right. This should be in the spec since it was introduced by the EIP.

@fjl
Copy link
Contributor

fjl commented Oct 27, 2025

Comment from @LukaszRozmej on RPC standards call: we should define the error behavior here. There should be an error when the block does not exist. The 4444 error should also be defined in case of missing history.

@fjl fjl merged commit f910189 into ethereum:main Oct 27, 2025
1 check passed
@fjl fjl removed the triage label Oct 27, 2025
@fjl
Copy link
Contributor

fjl commented Oct 28, 2025

It turns out we already have error 4444 defined for eth_getLogs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing blockHash property in Filter's scheme.

2 participants